Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render leisure=fitness_station #1870

Closed
naoliv opened this issue Sep 24, 2015 · 40 comments · Fixed by #2891
Closed

Render leisure=fitness_station #1870

naoliv opened this issue Sep 24, 2015 · 40 comments · Fixed by #2891

Comments

@naoliv
Copy link

naoliv commented Sep 24, 2015

Could we have leisure=fitness_station rendered too?

There is a CC-0 licensed icon here http://osm-icons.org/wiki/File:21009.svg

@kocio-pl
Copy link
Collaborator

Might work after some tweaking - let's start with just resizing to 14px:

  1. fitness_station-14-0

@HolgerJeromin
Copy link
Contributor

IMO the treadmill does indicate a indoor gym (which tagging is not clear).

You wont find a treadmill at an "outdoor facility" fitness_station

@naoliv
Copy link
Author

naoliv commented Sep 24, 2015

Maybe http://osm-icons.org/wiki/File:21157.svg ?
But it isn't good at 14x14:

@matkoniecz matkoniecz added this to the New features milestone Sep 27, 2015
@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 15, 2016

I guess a stepper would be good to depict, because it can be found both indoors and outdoors, so we could have just one icon for both leisure=fitness_station (3 573) and leisure=fitness_centre (2 611):

https://commons.wikimedia.org/wiki/File:Gym_Cardio_Area_Overlooking_Greenery.JPG
https://commons.wikimedia.org/wiki/File:Ansan_034.JPG

[EDIT:] BTW it looks like we no longer have a problem with tagging scheme - the numbers are clear to me:

http://wiki.openstreetmap.org/wiki/Gym_/_Fitness_centre#Taginfo

@boothym
Copy link
Contributor

boothym commented Sep 1, 2016

Both fitness_centre and fitness_station should be rendered, perhaps with some sort of weightlifting or treadmill icon.

With the gym tagging situation "sorted", I've updated the presets in the iD editor: openstreetmap/iD#3352 - would be nice to get a icon on the map as well.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 1, 2016

Ideas are welcome, of course, but at this moment we need rather implementations to test them.

@boothym
Copy link
Contributor

boothym commented Sep 15, 2016

Well the first one suggested doesn't look too bad at 14px - any chance you could show us what it looks like on the map?

@kocio-pl
Copy link
Collaborator

I guess if I make it look more like a stepper (change the silhouette) it could actually work for everybody. I will try to do it and show the rendering.

@boothym
Copy link
Contributor

boothym commented Sep 25, 2016

Even without the icon can we at least render the name for leisure=fitness_centre on a node, just like sports_centre? At the moment any properly tagged gym is invisible which doesn't help encourage people to tag it correctly.

@pnorman
Copy link
Collaborator

pnorman commented Sep 26, 2016

can we at least render the name for leisure=fitness_centre on a node, just like sports_centre?

This issue is about fitness stations, not fitness centres.

@boothym
Copy link
Contributor

boothym commented Sep 26, 2016

Ok, I'll open a new issue for that.

@Tomasz-W
Copy link

It's almost 7k of fitenss stations now.
https://taginfo.openstreetmap.org/tags/leisure=fitness_station

I think that fitness stations should be rendered not only as nodes, but as areas also. It's kind of landcover facility, so it should't make a blank hole in map, if it's mapped as area. Maybe playground colour with #1870 (comment) icon would look good. Playgrounds and fitness stations are similar objects, often standing side by side.

@kocio-pl
Copy link
Collaborator

I would also do it like this, but first we need icon like stepper (#1870 (comment)). It could be used also for fitness centre. Is there anybody who would like to draw such icon?

@Tomasz-W
Copy link

@kocio-pl I can try. What are the requirements for icon project file?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 26, 2017

Look here:

https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#map-icon-guidelines

You can take existing icon file and start with that (I was trying with this one). Inkscape is a free tool that I'm using. If you have more questions, just ask here or on the forum.

@Tomasz-W
Copy link

Tomasz-W commented Jul 27, 2017

What do you think about this icon?
fitness-station-bow
14x14 version: fitness-station-bow 14x14

@kocio-pl
Copy link
Collaborator

On a small scale:

  • head is too small
  • hands could be wider (especially lower hand)
  • rear leg should be probably also bent a bit
  • maybe handles should be more "X"-crossed to be better visible

Have you made an SVG version of it? Fixing it with PNG makes no sense, since optimal SVG lines should be pixel-aligned.

@Tomasz-W
Copy link

Tomasz-W commented Jul 27, 2017

Yes, I've made an svg version, so don't worry. I'll make changes due to your points and upload new version later.

@Tomasz-W
Copy link

2nd version
full-scale:
fitness station bow2
14x14: fitness-station-bow 14x142

@kocio-pl
Copy link
Collaborator

Thanks, that's much better! More leg bending would be nice, I would also try make both hands bolder (just as legs probably, because at 14px we need strong generalization) and move elbow half way between body and the handle, to be more visible. But overall view is now clear enough to me.

@Tomasz-W
Copy link

Tomasz-W commented Jul 27, 2017

3rd & 4th version, hands after workout ;)

I think this bolder hands made it's less visible on 14x14:
fitness station bow2
14x14: fitness station bow2 14x14

placing elbow half way between body and the handle also made it less visible, so here's version with bold hand near body:
fitness station bow3
14x14: fitness station bow3 14x14

I think that in 2nd version (#1870 (comment)) the "X" shape is the best visible, but you are more experienced, so you will know, which version is the best.

@naoliv
Copy link
Author

naoliv commented Jul 27, 2017

Version 2 seems better

@kocio-pl
Copy link
Collaborator

Could you share SVG image with version 2? Or maybe you'd like to make PR with leisure=fitness_station rendering?

@pnorman
Copy link
Collaborator

pnorman commented Aug 1, 2017

Could you render it with a pixel grid behind it to review the scale and alignment?

@meased
Copy link
Contributor

meased commented Aug 1, 2017

All I see are cross country skis.

What about a single dumbell?
dumbell

Or some kind of a "human-in-action"?
squat

Or a power lifter?
people

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 1, 2017

We don't look for nice free vector images, there's a lot of them around. We need them to look good enough as a 14 px icon, so try to scale them down first.

@Tomasz-W
Copy link

Tomasz-W commented Aug 2, 2017

I'm new to Inkscape (and making icons), so I'm not sure is it this what you mean, but here's screenshot of project with a grid:
bez tytulu

and exported to 14x14 png: eisure fitness_station

@pnorman
Copy link
Collaborator

pnorman commented Aug 2, 2017

I'm still not sure about the basic concept of the icon, but the bottom line should be horizontal and pixel aligned, and in general there are way too many sloped lines.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 12, 2017

I still haven't tried to make some tuning of this icon, but at least I think the color for all physical activity related icons and labels should be leisure-green (#2827).

@Tomasz-W: Oh, you still haven't published the SVG file itself? Please send this to a Gist for example, so I could modify it in Inkscape.

@Tomasz-W
Copy link

@kocio-pl https://gist.github.com/Tomasz-W/37318c37debf16e8b7cdc759b9b7eea4
Here you are.

@kocio-pl
Copy link
Collaborator

Unfortunately this icon don't work for me, even after tuning.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 9, 2017

After long time trying with different ideas I think the easiest would be to reuse sports icon - this should be pretty clear what it is because of using leisure green instead of shop violet and mirroring the symbol to make it more distinct. For me it works as unified icon for both fitness tags:

fitness centre
t_mkmr65

fitness station with current area color
2j2si2aq

or fitness station with playground area color
i0wlh2pl

@kocio-pl kocio-pl self-assigned this Oct 9, 2017
@Tomasz-W
Copy link

Tomasz-W commented Oct 9, 2017

IMO playground area colour would be better

@HolgerJeromin
Copy link
Contributor

You dont use a leisure=fitness_station with a kid. So please no playground colour

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 9, 2017

We have too many colors for very specific features and we're out of colors for at least 2 years, so it's good to make their meaning more general. I would say it should be called a "leisure background", so it fits both playground, fitness station and we use it for dog park too. Having different icons is enough to recognize them.

@dieterdreist
Copy link

dieterdreist commented Oct 9, 2017 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 9, 2017

The toilet icon is brown, so is the cinema icon - let's give them different colors! ...said nobody. Seriously - what color then and why?

Leisure is about different physical activity, it seems, so it all fits for me. That's why we have icons and patterns to differentiate things. Color is not the only thing that matters.

@Tomasz-W
Copy link

Tomasz-W commented Oct 9, 2017

You dont use a leisure=fitness_station with a kid. So please no playground colour

Why not? I've seen a lot of kids working out on outdoor gyms. Second thing - playgrounds and outdoor gyms are very similar objects, often placed side by side, so I don't see any problem with the same area colour for them both. With different icons and current dark-green outline (example here: http://www.openstreetmap.org/#map=19/52.39993/16.97736), I don't think it will be confusing, even if it's side by side.

@andrewharvey
Copy link

Glad to see this rendered on the map. I'm not sure about the icon though, to me the icon looks like a running track and when next to the path makes it look like the icon is showing that the path is a running track. fitness stations are typically about doing strength training, so some kind of weights icon like a dumbell might be better....

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 3, 2017

It has been proposed, but doesn't look good enough:

#1870 (comment)

However if you think you can make a better one, feel free to do it:

  • it has to be CC0/PD licensed
  • it has to be SVG
  • it has to look good as a 14px PNG
  • it would be good if it's unified for both types (fitness station and fitness center)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants