Skip to content

Commit

Permalink
Downgrade to postgis 2.5, fix password
Browse files Browse the repository at this point in the history
  • Loading branch information
hiddewie committed Jan 26, 2021
1 parent bf1e82c commit f701987
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.db
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
FROM postgis/postgis:10-3.1-alpine
FROM postgis/postgis:10-2.5-alpine

This comment has been minimized.

Copy link
@stephankn

stephankn Apr 20, 2021

I am running on my setup with postgis 3.1, so I am worried a bit now.
What is the reason for this downgrade? What problem did occur?

This comment has been minimized.

Copy link
@mboeringa

mboeringa Apr 21, 2021

Can't really speak for Hidde, but it does seem there is a current - yet to be properly verified - potential critical performance issue logged in the PostGIS bug tracker related to ST_Transform for PostGIS 3.1.x, that may or may not bite you depending on the type of workflow and processing you do:

https://trac.osgeo.org/postgis/ticket/4890

This comment has been minimized.

Copy link
@hiddewie

hiddewie Apr 21, 2021

Author Contributor

Initially, for the pull request #4294 which this commit is part of, I wanted to upgrade to PostGIS 3.1.

But the original image was mdillon/postgis:10 (diff: https://github.com/gravitystorm/openstreetmap-carto/pull/4294/files#diff-bd9115ede2e9c45b77debd8ac590acb3465c6aa5758ab6ec33b70cba2cffa12eL1) which contains PostGIS 2.5 (https://hub.docker.com/layers/mdillon/postgis/10/images/sha256-d8b6973b1142cff2120ed25e952344f03cb7e72c402b4ae9ada07beb3d093406?context=explore). I decided to keep the pull request 'safe' by not changing any versions functionally.

That is why I reverted from PostGIS 3.1 back to 2.5 within the pull request.

Good to note here: I saw no problems when running locally with PostGIS 3.1 (within the Docker image), so I see no problems for the upgrade in the future.

However, it would be good in this repository to keep the Docker versions of the software equivalent with the deployed versions of the software, to be able to reproduce any issues in production.


COPY ./scripts/tune-postgis.sh /docker-entrypoint-initdb.d/tune-postgis.sh
1 change: 1 addition & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ services:
ports:
- "127.0.0.1:5432:5432"
environment:
- POSTGRES_HOST_AUTH_METHOD=trust
- PG_WORK_MEM
- PG_MAINTENANCE_WORK_MEM
import:
Expand Down
4 changes: 2 additions & 2 deletions scripts/tune-postgis.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
set -e
export PGUSER="$POSTGRES_USER"

"${psql[@]}" -c "ALTER SYSTEM SET work_mem='${PG_WORK_MEM:-16MB}';"
"${psql[@]}" -c "ALTER SYSTEM SET maintenance_work_mem='${PG_MAINTENANCE_WORK_MEM:-256MB}';"
psql -c "ALTER SYSTEM SET work_mem='${PG_WORK_MEM:-16MB}';"
psql -c "ALTER SYSTEM SET maintenance_work_mem='${PG_MAINTENANCE_WORK_MEM:-256MB}';"

0 comments on commit f701987

Please sign in to comment.