add breaking change note in APIM upgrade guide about AE new default behaviour #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sendEventsOnHttp: false | ||
| ``` | ||
|
|
||
| Please refer to the AlertEngine documentation for more information: https://docs.gravitee.io/ae/apim_installation.html#event_sending_mode. |
There was a problem hiding this comment.
Suggested change
| Please refer to the AlertEngine documentation for more information: https://docs.gravitee.io/ae/apim_installation.html#event_sending_mode. | |
| Please see to the link:/ae/apim_installation.html#event_sending_mode[AlertEngine documentation] for more information. |
There was a problem hiding this comment.
In theory, I would agree, but because this README is included into another page and because of this bug asciidoctor/jekyll-asciidoc#166, I'm not sure the "link:" syntax will work
There was a problem hiding this comment.
In this case it does - I made the change locally and built it - but you are right to be cautious.
phiz71
force-pushed
the
add-note-in-apim-upgrade-guide
branch
from
b5279e9 to
ec59fc2
Compare
phiz71
force-pushed
the
add-note-in-apim-upgrade-guide
branch
from
ec59fc2 to
9a2ed29
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AndrewMcFarlandCampbellGravitee
approved these changes
Dec 22, 2022
|
Should we have held off with this merge until we had 3.20 out? |
|
Yes you're right, I forgot AE 2.0.0 will be released before APIM 🤦🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Add breaking change note in APIM upgrade guide about AE new default behaviour
🚀 CI was able to deploy the build of this PR, so you can now try it directly here