Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge every APIM README into one #857

Closed
wants to merge 2 commits into from

Conversation

phiz71
Copy link
Member

@phiz71 phiz71 commented Sep 30, 2022

Issue

N/A

Description

🚀 CI was able to deploy the build of this PR, so you can now try it directly here

@phiz71 phiz71 requested a review from a team as a code owner September 30, 2022 14:17
|=============

=== Repository
[#Mongodb-3_0_0]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor added so it can be referenced line 1587

link:https://raw.githubusercontent.com/gravitee-io/gravitee-api-management/master/gravitee-apim-repository/gravitee-apim-repository-mongodb/src/main/resources/scripts/3.0.0/6-remove-ALL-view-and-defaultView-field.js[/apim/3.x/mongodb/3.0.0/6-remove-ALL-view-and-defaultView-field.js]::
This script removes the 'All' *view*, since the legacy portal has been replaced and the new portal does not need this default view anymore. The script also updates existing views to remove *defaultView* field.

[#Upgrader-3_0_0]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor added so it can be referenced line 1588

Base automatically changed from apim_3.19 to master October 4, 2022 17:18
@phiz71 phiz71 requested a review from a team as a code owner October 4, 2022 17:18
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phiz71 phiz71 force-pushed the fix-computed-links-in-apim-upgrade-guide branch from 77ce8ba to d1878fb Compare October 4, 2022 17:24
@phiz71 phiz71 force-pushed the fix-computed-links-in-apim-upgrade-guide branch from d1878fb to 0bf3490 Compare October 21, 2022 06:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ghost
Copy link

ghost commented Nov 9, 2022

Hey @phiz71 - if you're happy with the current state of the PR, can we merge it today please?

@phiz71
Copy link
Member Author

phiz71 commented Nov 9, 2022

@ivan-gravitee, I think it deserves a quick review because the global upgrade guide may have changed since I opened the PR

@ghost
Copy link

ghost commented Nov 9, 2022

@phiz71 either that or we can abandon it as we're going to deprecate this framework imminently anyway. Can you perhaps test it quickly today on your side?

@phiz71
Copy link
Member Author

phiz71 commented Nov 10, 2022

I close this PR since the documentation framework will soon evolve and the current mechanism seems ok for the majority of the team.

@phiz71 phiz71 closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants