This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Indicate whether session.network events were allowed or blocked #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TEL-Q421-2 Fixes gravitational/teleport.e#331
reedloden
reviewed
May 2, 2022
packages/teleport/src/Audit/__snapshots__/Audit.story.test.tsx.snap
Outdated
Show resolved
Hide resolved
kimlisa
approved these changes
May 2, 2022
zmb3
added a commit
that referenced
this pull request
May 2, 2022
* Indicate whether session.network events were allowed or blocked Fixes TEL-Q421-2 Fixes gravitational/teleport.e#331
zmb3
added a commit
that referenced
this pull request
May 2, 2022
* Indicate whether session.network events were allowed or blocked Fixes TEL-Q421-2 Fixes gravitational/teleport.e#331
zmb3
added a commit
that referenced
this pull request
May 3, 2022
#801) * Indicate whether session.network events were allowed or blocked Fixes TEL-Q421-2 Fixes gravitational/teleport.e#331
zmb3
added a commit
that referenced
this pull request
May 3, 2022
#802) * Indicate whether session.network events were allowed or blocked Fixes TEL-Q421-2 Fixes gravitational/teleport.e#331
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only have a single event type for all
session.networkevents, whether the action was allowed or denied. This makes it hard for an administrator or auditor to detect malicious activity, because they have to look at the event JSON to get this info.Fix this by updating the description in the audit log to clearly indicate whether the action was allowed or denied.
Fixes TEL-Q421-2
Fixes gravitational/teleport.e#331