Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Show username when possible in identity list #687

Merged

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Mar 22, 2022

@gzdunek gzdunek requested a review from ravicious March 22, 2022 10:23
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It'll definitely benefit from gravitational/webapps.e#145 as right now it makes the picker show even less information since more of the cluster name is getting truncated. ;)

@gzdunek gzdunek force-pushed the gzdunek/show-username-when-possible-in-identity-list branch from 6275fa1 to 34deba9 Compare March 22, 2022 14:38
@gzdunek gzdunek force-pushed the gzdunek/show-username-when-possible-in-identity-list branch from 34deba9 to 7b471e0 Compare March 22, 2022 14:47
@gzdunek gzdunek merged commit 0b65709 into master Mar 22, 2022
@gzdunek gzdunek deleted the gzdunek/show-username-when-possible-in-identity-list branch March 22, 2022 15:04
ravicious added a commit that referenced this pull request Apr 27, 2022
* Take `localClusterUri` into account in `QuickInput` (#679)

* Display cluster name for each connection

* Automatically try to connect a connection when possible

* Update connection icon

* Always use root cluster URI to obtain `documentsService` in `useServerConnect`

* Don't close the tab on non-zero exit code

* Autocomplete database names for tsh proxy db

* Change placeholder text in `ClusterAdd`

* Show leaf cluster name when possible in Connections list

* Hide kubes and apps

* Force `TopBar` items to take full height

* Change shortcut to open `QuickInput`

* Update electron-builder to 23.0.3

Versions lower than 23.0.2 don't work on newest macOS, see:

* electron-userland/electron-builder#6732
* electron-userland/electron-builder#6606

* remove `Navigator` code (#685)

* Prevent breaking layout on long cluster name (#688)

* Show username when possible in identity list (#687)

* Update command for updating proto files

* Update protobufs for Teleterm (LoginRequest params)

This commit removes a bunch of unused protobufs and also updates some of
those that got updated on the teleterm branch in the teleport repo.

The biggest change from all of them is that LoginRequest now has oneof
on Sso and Local. [1] This is because a login request should have either
Sso or Local params, but not both at the same time.

The previous implementation called both `setSso` and `setLogin` on the same
object. This no longer works with the use of `oneof`, because calling `setLogin`
after `setSso` would clear the `Sso` params. [2]

[1] gravitational/teleport#10286 (comment)
[2] https://developers.google.com/protocol-buffers/docs/proto3#oneof_features

* Render ssh menu item as `NavLink` only when URL is provided

* Use connection dropdown instead of modal for supplying SSH username

* Adjust `Identity` layout, combine `logout` and `clusterRemove` into a single action

* Change command `cluster-remove` to `cluster-logout`

* Apply `Identity` design changes

* Enable `babel-plugin-styled-components` in production and tests (#697)

* Make connections icon bigger

* Properly use `css` prop

Co-authored-by: Grzegorz Zdunek <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants