This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Maintain aspect ratio on Desktop Playback #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2022 18:51
…ar to its own file
…ogic which prevents a jarring movement of the progress bar on load
hatched
approved these changes
Mar 1, 2022
zmb3
reviewed
Mar 1, 2022
| @@ -141,20 +94,40 @@ const useDesktopPlayer = ({ | |||
| canvas: HTMLCanvasElement, | |||
| spec: ClientScreenSpec | |||
| ) => { | |||
| const styledPlayer = canvas.parentElement; | |||
There was a problem hiding this comment.
Do we need to run this logic on every PNG frame? Or can we instead run it once when we initialize the player and (optionally) run it in a window resize handler?
There was a problem hiding this comment.
It's only being run when we receive the client screen spec tdp message, so since we currently don't support a dynamic resize, it just happens once at the beginning. Once we do implement resize, this will also account for that.
There was a problem hiding this comment.
Oh! Github's UI confuses me, I looked up and it looked like this was inside tdpCliOnPngFrame, but it's not. My eyes always glance over the light blue bars. Sorry!
zmb3
approved these changes
Mar 1, 2022
kimlisa
added a commit
to gravitational/webassets
that referenced
this pull request
Mar 2, 2022
kimlisa
added a commit
to gravitational/teleport
that referenced
this pull request
Mar 2, 2022
a18685fe Maintain aspect ratio on Desktop Playback (gravitational/webapps#635) gravitational/webapps@a18685fe [source: -w master] [target: -t master]
ibeckermayer
pushed a commit
that referenced
this pull request
Mar 7, 2022
Merged
ibeckermayer
pushed a commit
that referenced
this pull request
Mar 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, desktop sessions recorded at one aspect ratio and played at another could look insane (see the screenshot in #587). These changes maintain the aspect ratio during playback.
Playback aspect ratio > recorded aspect ratio
Playback aspect ratio < recorded aspect ratio
RFD
Due to slight differences between the size available to the desktop session during recording, and the size available to the player, a session recorded and then played back in a browser window of precisely the same size may look something like this:
Note the black channels up and down the left and right size of the window, which are created by the same logic that creates the desirable, necessary black-space in the
Playback aspect ratio > recorded aspect ratioscreen shot above. I'm not ecstatic about how that looks, but am not sure precisely what to do about it (if anything).closes #587