Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Update FormLogin.tsx #608

Merged
merged 9 commits into from
Mar 2, 2022
Merged

Update FormLogin.tsx #608

merged 9 commits into from
Mar 2, 2022

Conversation

t-rutter
Copy link
Contributor

Changed login form 'Authenticator code' input field type from 'text' to 'tel'.
In html the two are functional the same, But allows for client improvements for number input.

Allows 'Authenticator code' autofill on iOS 15 and Safari 15 .
On other devices an the onscreen keyboard may change to an number pad for easier code input.

@t-rutter
Copy link
Contributor Author

Cloud someone please test this .😄 thanks
Referenced from gravitational/teleport#10389

@Valien Valien requested a review from zmb3 February 22, 2022 21:14
@Valien Valien added the enhancement New feature or request label Feb 22, 2022
@zmb3 zmb3 requested a review from kimlisa February 22, 2022 21:15
@kimlisa
Copy link
Contributor

kimlisa commented Feb 22, 2022

Thanks for the PR! We need to update typing and fix a snapshot before this can be merged. If you'd like to do this, the instructions are below, otherwise we are happy to take over:

Step 1: in FieldInput component, add a type 'tel'
Step 2: update snapshot yarn test -u FormLogin.test

@t-rutter
Copy link
Contributor Author

Ok, I think I figured it out.
I've ran

brew install yarn

Then in the repo folder

yarn install
yarn test -u FormLogin.test
and then
yarn run test

But got an errors in 'packages/teleport/src/components/FormLogin/FormLogin.story.test.tsx'.
So also ran

yarn test -u FormLogin.story.test
then
yarn run test
:D no errors reported

Even managed to work out the dev proxy test

yarn start-teleport --target=https://teleport.mydomain.com:443/web
It looks like it works, autofills in safari or numberpad is displayed when entering the code

Updated FormLogin story snapshot
@kimlisa
Copy link
Contributor

kimlisa commented Feb 24, 2022

awesome, just one more change needed to get the tests passing, in FieldInput file, add a type 'tel': | 'tel'

Added  type 'tel' to FieldInput
@kimlisa
Copy link
Contributor

kimlisa commented Feb 24, 2022

/gcbrun

@t-rutter
Copy link
Contributor Author

/gcbrun

The test did pass, But it seam when I Merged the current to my Fork it removed the test results.
@kimlisa could you please run /gcbrun again, I wont touch my master until the PR is merged this time

@kimlisa
Copy link
Contributor

kimlisa commented Feb 27, 2022

/gcbrun

@zmb3
Copy link
Contributor

zmb3 commented Mar 2, 2022

/gcbrun

@zmb3
Copy link
Contributor

zmb3 commented Mar 2, 2022

Thanks for the contribution, @t-rutter 🙌

@zmb3 zmb3 enabled auto-merge (squash) March 2, 2022 22:57
@zmb3
Copy link
Contributor

zmb3 commented Mar 2, 2022

/gcbrun

@zmb3
Copy link
Contributor

zmb3 commented Mar 2, 2022

/gcbrun

@zmb3 zmb3 merged commit 5f8aef1 into gravitational:master Mar 2, 2022
kimlisa added a commit to gravitational/webassets that referenced this pull request Mar 3, 2022
kimlisa added a commit to gravitational/teleport that referenced this pull request Mar 3, 2022
5f8aef1b Update FormLogin.tsx (gravitational/webapps#608) gravitational/webapps@5f8aef1b

[source: -w master] [target: -t master]
kimlisa added a commit to gravitational/teleport that referenced this pull request Mar 3, 2022
5f8aef1b Update FormLogin.tsx (gravitational/webapps#608) gravitational/webapps@5f8aef1b

 - number pad popup for number inputs
 - disable auto complete on ssh login input
 - fix spelling
 - simplify manual instructions for nodes
 - update api responses for get resources (wrapped in obj)
 - enterprise versions supply enterprise download links
 - include cluster name with `tsh login` for kube instruction
 - windows desktop
   - maintain aspect ratio
   - fix clipboard sync
   - per session mfa

[source: -w master] [target: -t master]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants