Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ProgressBarDesktop when an unknown error occurs #21071

Closed
ibeckermayer opened this issue Mar 4, 2022 · 0 comments
Closed

Stop ProgressBarDesktop when an unknown error occurs #21071

ibeckermayer opened this issue Mar 4, 2022 · 0 comments
Assignees

Comments

@ibeckermayer
Copy link
Contributor

This listener was removed from ProgressBarDesktop, since in the typical case of a playback, the websocket is closed by the server before the progress bar has reached its final destination, so we don't want to stopProgress. The original impetus for adding it was to make the progress bar stop if the websocket closed unexpectedly (when we get a connection to the server failed for an unknown reason).

Refactor the ProgressBarDesktop so that it can be stopped if this websocket closure was due to an unexpected error rather than a normal operation. This logic is handled in useDesktopPlayer, and will probably involve abstracting out a useProgressBarDesktop that can be invoked from within there and passed into the ProgressBarDesktop, so that ProgressBarDesktop's behavior can be modified from useDesktopPlayer.

@ibeckermayer ibeckermayer self-assigned this Mar 4, 2022
ibeckermayer referenced this issue in gravitational/webapps Mar 4, 2022
* smooths out progress bar

* refactors updateCurrentTime to be able to be used more flexibly, removes the WS_CLOSE listener (see https://github.com/gravitational/webapps/issues/649)
hatched referenced this issue in hatched/teleport-merge Nov 30, 2022
* smooths out progress bar

* refactors updateCurrentTime to be able to be used more flexibly, removes the WS_CLOSE listener (see https://github.com/gravitational/webapps/issues/649)
hatched referenced this issue Dec 20, 2022
* smooths out progress bar

* refactors updateCurrentTime to be able to be used more flexibly, removes the WS_CLOSE listener (see https://github.com/gravitational/webapps/issues/649)
@hatched hatched transferred this issue from gravitational/webapps Feb 1, 2023
@hatched hatched added the ui label Feb 1, 2023
@zmb3 zmb3 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants