You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This listener was removed from ProgressBarDesktop, since in the typical case of a playback, the websocket is closed by the server before the progress bar has reached its final destination, so we don't want to stopProgress. The original impetus for adding it was to make the progress bar stop if the websocket closed unexpectedly (when we get a connection to the server failed for an unknown reason).
Refactor the ProgressBarDesktop so that it can be stopped if this websocket closure was due to an unexpected error rather than a normal operation. This logic is handled in useDesktopPlayer, and will probably involve abstracting out a useProgressBarDesktop that can be invoked from within there and passed into the ProgressBarDesktop, so that ProgressBarDesktop's behavior can be modified from useDesktopPlayer.
The text was updated successfully, but these errors were encountered:
This listener was removed from
ProgressBarDesktop
, since in the typical case of a playback, the websocket is closed by the server before the progress bar has reached its final destination, so we don't want tostopProgress
. The original impetus for adding it was to make the progress bar stop if the websocket closed unexpectedly (when we get aconnection to the server failed for an unknown reason
).Refactor the
ProgressBarDesktop
so that it can be stopped if this websocket closure was due to an unexpected error rather than a normal operation. This logic is handled inuseDesktopPlayer
, and will probably involve abstracting out auseProgressBarDesktop
that can be invoked from within there and passed into theProgressBarDesktop
, so thatProgressBarDesktop
's behavior can be modified fromuseDesktopPlayer
.The text was updated successfully, but these errors were encountered: