[v7] Run gpg in batch mode #9731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not prompt for any reason, especially not if a repomd.xml.asc already exists when signing repomd.xml. Attempting to prompt (instead of overwriting) results in publish failures like the following: + gpg --detach-sign --armor /rpmrepo/teleport/repodata/repomd.xml gpg: cannot open '/dev/tty': No such device or address Contributes to #9726. (cherry picked from commit 0fb71e9)
zmb3
approved these changes
Jan 11, 2022
fspmarshall
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v7 backport of #9728
Summary
This fixes a release bug when gpg attempts to sign repomd.xml when a signature is already present.
Contributes to #9726.
Testing Done
See #9728. No additional testing was done for this PR.