-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "create database agent configuration" CLI command #9618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
rfd
Request for Discussion
tctl
tctl - Teleport admin tool
labels
Jan 3, 2022
gabrielcorado
force-pushed
the
gabrielcorado/create-database-config
branch
2 times, most recently
from
January 10, 2022 20:45
1da64d1
to
13c39ef
Compare
gabrielcorado
added
cli
Tickets related to CLI experience
and removed
documentation
rfd
Request for Discussion
tctl
tctl - Teleport admin tool
labels
Jan 10, 2022
quinqu
suggested changes
Jan 11, 2022
gabrielcorado
force-pushed
the
gabrielcorado/create-database-config
branch
3 times, most recently
from
January 25, 2022 15:21
fb54e6d
to
2da45cd
Compare
r0mant
reviewed
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabrielcorado In addition to the comments I left, this PR also needs test coverage.
gabrielcorado
force-pushed
the
gabrielcorado/create-database-config
branch
3 times, most recently
from
February 3, 2022 16:03
b90e1af
to
47b00ba
Compare
@r0mant Thanks for the review. I added test coverage and the Redshift flag. |
gabrielcorado
force-pushed
the
gabrielcorado/create-database-config
branch
from
February 3, 2022 16:08
47b00ba
to
2049432
Compare
r0mant
approved these changes
Feb 10, 2022
smallinsky
approved these changes
Feb 10, 2022
gabrielcorado
force-pushed
the
gabrielcorado/create-database-config
branch
from
February 10, 2022 17:07
2049432
to
a2ea000
Compare
gabrielcorado
force-pushed
the
gabrielcorado/create-database-config
branch
from
February 10, 2022 17:12
a2ea000
to
73446c2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #8974. It implements the command
teleport db configure create
, which will generate database agent configurations (similar to theteleport configure
command).This command was introduced at #9719.