Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "create database agent configuration" CLI command #9618

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

gabrielcorado
Copy link
Contributor

@gabrielcorado gabrielcorado commented Jan 3, 2022

This PR is part of #8974. It implements the command teleport db configure create, which will generate database agent configurations (similar to the teleport configure command).

This command was introduced at #9719.

@gabrielcorado gabrielcorado self-assigned this Jan 3, 2022
@github-actions github-actions bot added documentation rfd Request for Discussion tctl tctl - Teleport admin tool labels Jan 3, 2022
@gabrielcorado gabrielcorado force-pushed the gabrielcorado/create-database-config branch 2 times, most recently from 1da64d1 to 13c39ef Compare January 10, 2022 20:45
@gabrielcorado gabrielcorado added cli Tickets related to CLI experience and removed documentation rfd Request for Discussion tctl tctl - Teleport admin tool labels Jan 10, 2022
lib/config/database.go Outdated Show resolved Hide resolved
lib/config/database.go Outdated Show resolved Hide resolved
lib/config/database.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Show resolved Hide resolved
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
@gabrielcorado gabrielcorado force-pushed the gabrielcorado/create-database-config branch 3 times, most recently from fb54e6d to 2da45cd Compare January 25, 2022 15:21
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielcorado In addition to the comments I left, this PR also needs test coverage.

lib/config/database.go Outdated Show resolved Hide resolved
lib/config/database.go Outdated Show resolved Hide resolved
lib/config/database.go Outdated Show resolved Hide resolved
tool/tctl/common/db_command.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
tool/teleport/common/usage.go Outdated Show resolved Hide resolved
tool/teleport/common/usage.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
tool/teleport/common/teleport.go Show resolved Hide resolved
lib/config/database.go Show resolved Hide resolved
@gabrielcorado gabrielcorado force-pushed the gabrielcorado/create-database-config branch 3 times, most recently from b90e1af to 47b00ba Compare February 3, 2022 16:03
@gabrielcorado
Copy link
Contributor Author

@r0mant Thanks for the review. I added test coverage and the Redshift flag.

@gabrielcorado gabrielcorado force-pushed the gabrielcorado/create-database-config branch from 47b00ba to 2049432 Compare February 3, 2022 16:08
lib/config/database.go Outdated Show resolved Hide resolved
lib/config/database.go Outdated Show resolved Hide resolved
@gabrielcorado gabrielcorado force-pushed the gabrielcorado/create-database-config branch from 2049432 to a2ea000 Compare February 10, 2022 17:07
@gabrielcorado gabrielcorado enabled auto-merge (squash) February 10, 2022 17:07
@gabrielcorado gabrielcorado force-pushed the gabrielcorado/create-database-config branch from a2ea000 to 73446c2 Compare February 10, 2022 17:12
@gabrielcorado gabrielcorado merged commit df68e73 into master Feb 10, 2022
@gabrielcorado gabrielcorado deleted the gabrielcorado/create-database-config branch February 10, 2022 17:56
@jimbishopp jimbishopp mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Tickets related to CLI experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants