Only allow access request deletion through static roles' permissions #9540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@russjones after this change the web UI will still allow the user to click the "delete" button on the access request if an elevated role would allow it, displaying an error message after confirmation. The code that ultimately decides what operations are shown as available to the user ( |
espadolini
force-pushed
the
espadolini/access-request-deletion
branch
from
8e1ce99 to
55d4347
Compare
|
@espadolini Please add test coverage to this PR. |
espadolini
force-pushed
the
espadolini/access-request-deletion
branch
2 times, most recently
from
e92771a to
3a254df
Compare
atburke
approved these changes
Dec 30, 2021
espadolini
force-pushed
the
espadolini/access-request-deletion
branch
from
3a254df to
d18f9d1
Compare
fspmarshall
approved these changes
Dec 31, 2021
espadolini
force-pushed
the
espadolini/access-request-deletion
branch
from
d18f9d1 to
877b815
Compare
espadolini
force-pushed
the
espadolini/access-request-deletion
branch
from
877b815 to
d8a482c
Compare
|
@russjones which backports, if any? |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access request deletion is not meant to be used on a regular basis, and in fact it's not an operation that
tshsupports; it's however supported via gRPC and the web interface. Letting a temporarily privileged user delete access requests can lead to reduced visibility over the action of the user, and can cause confusion if the cert authority needs to reference that access request to issue more certificates for other purposes.This partially mitigates TEL-Q321-8.