Add support for MariaDB #9409
Merged
Add support for MariaDB #9409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakule
force-pushed
the
jakule/mariadb-support
branch
from
461eb95 to
47fb525
Compare
github-actions
bot
requested review from
gabrielcorado,
klizhentas,
ptgott and
zmb3
gabrielcorado
approved these changes
Jan 4, 2022
tool/tsh/db.go
Outdated
| // Check if mysql comes from Oracle or MariaDB | ||
| mysqlVer, err := c.exe.RunCommand(mysqlBin, "--version") | ||
| if err != nil { | ||
| // Looks like incorrect mysql installation or mysql binary is missing. |
There was a problem hiding this comment.
Nit: I think this comment will make more sense if placed in the getMySQLCommand since it is where the decision to go and use Oracle's version in case of error.
There was a problem hiding this comment.
As @r0mant suggested I changed the logic a bit. I changed the comment as now we have an explicit check for mysql.
zmb3
approved these changes
Jan 4, 2022
add test
jakule
force-pushed
the
jakule/mariadb-support
branch
from
f7ff17a to
a010afb
Compare
|
@klizhentas Can you take a look on the docs changes? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for MariaDB. Binary protocol is the same as MySQL, so there is no changes in the backend logic. Default client for MySQL and MariaDB from now on will be
mariadbormysqlif the first one is not available in the system.I also added tests for all CLI tools run by
tsh db connect.closes #8904