Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-compose: Update default images used to version 6 #7055

Merged
merged 5 commits into from
Jun 7, 2021
Merged

docker-compose: Update default images used to version 6 #7055

merged 5 commits into from
Jun 7, 2021

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented May 26, 2021 •
edited
Loading

Updates default Docker image number in docker-compose files.

Backports required:

  • branch/v6
  • branch/v6.1
  • branch/v6.2

Updates #7030

@webvictim webvictim requested review from wadells, awly and quinqu May 26, 2021 17:05
@webvictim webvictim self-assigned this May 26, 2021
@webvictim webvictim mentioned this pull request May 26, 2021
Closed
7 tasks
wadells
wadells approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@wadells wadells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be at 7 for master, and 6 for the backports?

@webvictim
Copy link
Contributor Author

Should these be at 7 for master, and 6 for the backports?

We don't publish Docker images from master (at least currently), so the 7 tag doesn't exist. Arguably it should, though.

@wadells
Copy link
Contributor

wadells commented May 26, 2021 •
edited
Loading

Should these be at 7 for master, and 6 for the backports?

We don't publish Docker images from master (at least currently), so the 7 tag doesn't exist. Arguably it should, though.

Hmm ... definately not something for this PR (6 is great) but perhaps we have a floating and obviously pre-release tag for use with master. Then when 7.0 is cut the release process would include changing that to 7. Just spitballing ideas.

@webvictim webvictim enabled auto-merge (squash) May 26, 2021 20:12
@webvictim
Copy link
Contributor Author

#6970 covered teleport-quickstart.yml but missed teleport-ent-quickstart.yaml. As such, that PR should also be included when backporting this one.

@webvictim webvictim mentioned this pull request May 26, 2021
Merged
russjones
russjones approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@webvictim webvictim merged commit 0af3d2f into master Jun 7, 2021
@webvictim webvictim deleted the gus/update-docker-versions branch June 7, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russjones russjones russjones approved these changes

@awly awly awly approved these changes

@wadells wadells wadells approved these changes

@quinqu quinqu Awaiting requested review from quinqu

@klizhentas klizhentas Awaiting requested review from klizhentas

@r0mant r0mant Awaiting requested review from r0mant

Assignees

@webvictim webvictim

Labels
backport-required release-engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@webvictim @wadells @awly @russjones