-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AMI IDs for 6.2.0 #7037
Merged
Merged
Update AMI IDs for 6.2.0 #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow MacOS default bash is version 3 (even on 11.3). You can install v5 using Brew, but it gets linked to /usr/local/bin/bash. Changing the shebang to use `env` will use whichever `bash` appears in the PATH first, which is more cross-platform friendly.
webvictim
added
automated
PRs raised by automation
terraform-deployment-examples
Issues relating to Terraform deployment examples under examples/aws/terraform
labels
May 25, 2021
wadells
approved these changes
May 25, 2021
7 tasks
quinqu
approved these changes
May 26, 2021
russjones
approved these changes
May 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bot.
Backports required:
|
webvictim
added a commit
that referenced
this pull request
May 27, 2021
webvictim
added a commit
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automated
PRs raised by automation
backport-required
terraform-deployment-examples
Issues relating to Terraform deployment examples under examples/aws/terraform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #6282 and its backports added support for AMIs in other AWS regions, the script which handles making the AMIs public as part of the Drone promotion step (https://github.com/gravitational/teleport/blob/master/assets/aws/files/make-amis-public.sh) still had a hardcoded region list which was not updated at the same time.
This PR removes that region list and passes it through from the single source of truth in the
Makefile
instead so this doesn't happen again. I've manually made the affected AMIs public myself now.This PR also:
#!/usr/bin/env bash
instead of just#/bin/bash
so they also work on systems which alter the default path tobash
(such as when youbrew install bash
on MacOS, which goes to/usr/local/bin/bash
)coreutils
,findutils
andgnu-sed
to run directly on MacOSBackports required to:
branch/v6
branch/v6.2
Updates #7030