[6.1.2] Backport - Improve process connection error handling and logging (#6471) #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
changed the title
Joerger
changed the title
Joerger
changed the title
|
Not totally sure if it's the case here, but I wanted to share some experience with troubleshooting in gravity. If this works like there is a connection attempt made, that in most configurations fail, and then it falls back into another mechanism in which most configurations will succeed, it makes it difficult to troubleshoot if the first mechanism is expected to work in a particular configuration. I don't know what the best advice is, but I would probably try to stash the error and bubble up both if that's applicable here. Just wanted to share, since it came up a few times where troubleshooting gravity with fallback logic that might be similar. |
awly
reviewed
Apr 14, 2021
Joerger
force-pushed
the
joerger/backport-6.1/fix/direct-connect-failure-log
branch
from
b706867 to
108e4a2
Compare
Joerger
changed the title
awly
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #6471