Adding OIDC auth functionality to the Azure integration #51219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
reviewed
Jan 20, 2025
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-srv
branch
from
c3292e2 to
15f12a5
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-oidc
branch
from
e96050c to
9f1be00
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-srv
branch
from
15f12a5 to
76a9d34
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-oidc
branch
from
526a053 to
a540f88
Compare
tigrato
approved these changes
Jan 23, 2025
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-oidc
branch
from
27f36b1 to
1343b20
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-srv
branch
from
c86b4a3 to
10feddd
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-oidc
branch
2 times, most recently
from
c081831 to
fa43980
Compare
Base automatically changed from
mvbrock/azure-integration-disco-azure-srv
to
master
January 23, 2025 16:56
Co-authored-by: Tiago Silva <[email protected]>
…g a credential assertion approach
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-oidc
branch
from
fa43980 to
ebcdab8
Compare
mvbrock
added
the
no-changelog
marcoandredinis
approved these changes
Jan 23, 2025
public-teleport-github-review-bot
bot
removed request for
kopiczko and
strideynet
This was referenced Jan 31, 2025
mvbrock
added a commit
that referenced
this pull request
Jan 31, 2025
* Protobuf and configuration for Access Graph Azure Discovery * Fixing rebase after protobuf gen * Updating to use existing msgraph client * PR feedback * Using variadic options * Removing memberOf expansion * Expanding memberships by calling memberOf on each user * PR feedback * Rebase go.sum stuff * Go mod tidy * Fixing go.mod * Update lib/msgraph/paginated.go Co-authored-by: Tiago Silva <[email protected]> * PR feedback * Protobuf and configuration for Access Graph Azure Discovery * Adding Azure sync functionality which can be called by the Azure fetcher * Protobuf update * Linting * PR feedback * PR feedback * Updating to use existing msgraph client * PR feedback * Using variadic options * Removing memberOf expansion * Expanding memberships by calling memberOf on each user * PR feedback * Rebase go.sum stuff * PR feedback * Protobuf and configuration for Access Graph Azure Discovery * Protobuf gen fix * Rebase fixes * More cleanup * e ref update * Invoking token generation and returning the response * Quick test with a message to make sure RPC is invoked * Skeleton of new Azure OIDC RPC call * Fetching the Azure OIDC token during fetcher creation and establishing a credential assertion approach * PR feedback; restricting token requests to auth, discovery, and proxy roles. * Lint * Fixing mocks * Fix imports * Fix test * Rebase fxes * Adding back OIDC fetching, accidentally removed it during rebase * e ref * Lint * Fix imports --------- Co-authored-by: Tiago Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/gravitational/access-graph/issues/640, this PR adds OIDC auth functionality to the Azure integration. If an Azure OIDC integration is configured, the Azure integration functionality can be configured to use the Auth server's authorized keypair to generate an Azure token for generating credentials. These credentials can then be used to fetch Azure resources.