[vnet] refactor AppProvider for Windows implementation #51216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
no-changelog
github-actions
bot
added
size/md
tsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RFD 195.
This PR refactors the way that the VNet client applications (Connect and
tsh vnet) provide teleport clients and other functionality to the VNet library. The goal is to move toward an interface that can be implemented locally OR over gRPC so that the VNet Windows service can interact with the client application from another process.The current implementation (prior to this change) has both clients implementing an interface called
vnet.AppProvider. In this PR, each client now implementsvnet.ClientApplication.vnet.localAppProvidernow wrapsvnet.ClientApplicationto implement the now-unexportedvnet.appProvider. In a following PR, I will add avnet.remoteAppProviderthat also implements this interface but interacts with the client application over gRPC.This is basically a rewrite of lib/vnet/app_resolver.go so the diff may not be very useful there, but the new code on its own should be reviewable.