Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Move the new role editor to a full-screen dialog #50134

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Dec 12, 2024

Backport #49881 to branch/v17

* Add admin rule tab to the role editor

Also tightens some constraints about standard role editor conformance.

* Add a way to delete an admin rule

* Add the options panel to role editor

* Move RoleEditorAdapter to a separate file

* Move the role editor to a full-screen dialog

* Review

* Review

* Review

* Lint

* Review
@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Dec 12, 2024
@bl-nero bl-nero marked this pull request as ready for review December 12, 2024 11:55
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-50134.d212ksyjt6y4yg.amplifyapp.com

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from kiosion December 13, 2024 00:58
@bl-nero bl-nero added this pull request to the merge queue Dec 13, 2024
Merged via the queue into branch/v17 with commit ec2a925 Dec 13, 2024
46 checks passed
@bl-nero bl-nero deleted the bl-nero/backport-49881-branch/v17 branch December 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants