Disable resetting to the standard model #50048
Conversation
bl-nero
added
no-changelog
| Some fields were not readable by the standard editor. To continue editing, | ||
| go back to YAML editor or reset the affected fields to standard settings. | ||
| go back to YAML editor. |
There was a problem hiding this comment.
"Some fields were not readable by the standard editor" hints like some bug that I think does not provide any value to the user.
Maybe some variations of the two sentences below?
- Standard editor is not supported this time. To continue editing, please go back to the YAML editor.
- Standard editor is coming soon. To continue editing, please go back to the YAML editor.
There was a problem hiding this comment.
"This time" suggest that it's a transient issue, and the user should try again later. "Coming soon" suggests that standard editor is not available at all. I think "This role is too complex to be edited in standard editor" will be the best message.
There was a problem hiding this comment.
Are we disabling standard editor by default or just in a few scenario?
There was a problem hiding this comment.
Yes, this is just in these scenarios. #50067 bridges the gap close enough to support built-in editor and auditor roles, but the access role uses a bit that we're still unsure how to represent. Also, for simplicity, deny rules are dropped from this release.
bl-nero
force-pushed
the
bl-nero/role-editor-no-reset
branch
from
693af12 to
431c84c
Compare
bl-nero
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
bl-nero
removed request for
klizhentas,
r0mant,
russjones,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
bl-nero
force-pushed
the
bl-nero/role-editor-no-reset
branch
from
431c84c to
bb12ddf
Compare
* Disable resetting to the standard model * Review * Test fix * Fix a test
Until we come up with a more trustworthy user experience, we don't want to risk throwing the users under the bus by performing actions that are not detailed in the UI and that would be difficult to understand for the users because of the level of complication of the editor's model. Just display the message and disable the standard editor UI.