Expose /.well-known/jwks-okta for Okta API services type App #50040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopiczko
commented
Dec 10, 2024
| "github.com/gravitational/teleport/lib/jwt" | ||
| "github.com/gravitational/trace" | ||
| ) | ||
|
|
There was a problem hiding this comment.
jwks(...) was moved from lib/web/oidcidp.go
kopiczko
force-pushed
the
kopiczko/add-jwks-okta-endpoint
branch
2 times, most recently
from
52611c0 to
ddb3434
Compare
marcoandredinis
approved these changes
Dec 11, 2024
codingllama
reviewed
Dec 11, 2024
| "github.com/gravitational/teleport/lib/jwt" | ||
| "github.com/gravitational/trace" | ||
| ) | ||
|
|
smallinsky
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
LGTM after addressing https://github.com/gravitational/teleport/pull/50040/files#r1880383126
codingllama
reviewed
Dec 11, 2024
codingllama
approved these changes
Dec 12, 2024
kopiczko
force-pushed
the
kopiczko/add-jwks-okta-endpoint
branch
2 times, most recently
from
a496200 to
0748be2
Compare
|
@kopiczko - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
|
WTH, something went very wrong with my squash |
kopiczko
force-pushed
the
kopiczko/add-jwks-okta-endpoint
branch
2 times, most recently
from
a496200 to
3a65dad
Compare
kopiczko
force-pushed
the
kopiczko/add-jwks-okta-endpoint
branch
from
3a65dad to
ba94e66
Compare
|
🤖 Vercel preview here: https://docs-el80x8180-goteleport.vercel.app/docs |
kopiczko
force-pushed
the
kopiczko/add-jwks-okta-endpoint
branch
from
ba94e66 to
27b69fb
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thanks @codingllama for trough review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/gravitational/teleport.e/issues/5517
When configured to use OAuth credentials Okta client uses JWT tokens signed with Okta CA. We need to expose JWKS URL to be able to easily configure public key for signature verification.
changelog: Expose /.well-known/jwks-okta public endpoint for Okta API services type App.