DiscoveryConfig Status: update even when no resources are found

[marcoandredinis]

The DiscoveryService was not updating the DiscoveryConfigStatus when its matchers didn't discovered any resource.

This would lead the user to think that there the DiscoveryConfig was not being processed, when in fact it was.

Demo:
$ tctl get discovery_config | yq .status

discovered_resources: 0
last_sync_time: "2024-11-29T16:45:54.51056Z"
state: DISCOVERY_CONFIG_STATE_SYNCING
---
discovered_resources: 0
last_sync_time: "2024-11-29T17:17:59.196886Z"
state: DISCOVERY_CONFIG_STATE_SYNCING
---
discovered_resources: 0
last_sync_time: "2024-11-29T17:17:59.196586Z"
state: DISCOVERY_CONFIG_STATE_SYNCING
---
discovered_resources: 0
last_sync_time: "2024-11-29T16:45:54.760152Z"
state: DISCOVERY_CONFIG_STATE_SYNCING

[marcoandredinis]

@atburke @r0mant Can you please take a look when you get a chance?

[r0mant]

Tbh I'm not a huge fan of the fact that we need to propagate this discovery config as an extra parameter everywhere. Seems very tightly coupled. Is there a cleaner way to achieve this?

[marcoandredinis]

DiscoveryConfig contains Matchers, which create Fetchers.
Fetchers find resources and enrolls them. When it fails, we must update the DiscoveryConfigStatus / UserTasks and we need the DiscoveryConfig name.

So, what I'm doing is adding the DiscoveryConfig name into the Fetcher, so that when it tries to auto-enroll resources and it fails, it is able to identify which DiscoveryConfig was used.

I don't think there's a way to achieve this without passing the DiscoveryConfig name into the Fetcher.
We can create a new type that includes the DiscoveryConfigName as well as the Matcher. Something like this:

type MatcherFromDiscoveryConfig struct {
    DiscoveryConfigName string
    AzureMatcher types.AzureMatcher
    AWSMatcher types.AWSMatcher
    GCPMatcher types.GCPMatcher
}

And when creating the Fetcher, we would get the DiscoveryConfigName from this new type, instead of as a param.
I'm not too fond of this, and would rather keep it as is.
Please let me know what you think.

[marcoandredinis]

@r0mant Can I please get another pass on this one? (next week is fine)