Add test that executes tsh with no env vars #49255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
no-changelog
github-actions
bot
added
size/sm
tsh
zmb3
reviewed
Nov 20, 2024
tool/tsh/common/tsh_test.go
Outdated
| testExecutable, err := os.Executable() | ||
| require.NoError(t, err) | ||
| // Execute an actual command and not jut `tsh help` which goes through a different code path. | ||
| cmd := exec.Command(testExecutable, "version", "--client") |
There was a problem hiding this comment.
Should we use CommandContext and provide a context with a 5-10s deadline?
zmb3
approved these changes
Nov 20, 2024
bernardjkim
approved these changes
Nov 20, 2024
public-teleport-github-review-bot
bot
removed the request for review
from smallinsky
Co-authored-by: Bernard Kim <[email protected]>
|
@ravicious See the table below for backport results.
|
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we introduced a regression in VNet where the tsh auto-updater would assume that
$HOMEis present when running tsh (#47815 (comment)). It turns out that when launchd starts VNet's launch daemon and executestsh vnet-daemon, it does so without providing any of the "regular" env variables.This has been fixed in #49159. This PR adds a test which hopefully catches similar regressions in the future.
This test fails on the parent commit of #49159 with: