Simplify Lint (Docs) #48845
Merged
Simplify Lint (Docs) #48845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ptgott
force-pushed
the
paul.gottschling/2024-11-12-no-submodules
branch
from
5c23cd4 to
637602f
Compare
Currently, `Lint (Docs)` configures git submodules for `gravitational/teleport` within a `gravitational/docs` clone based on the value of `$GITHUB_REF` or `$GITHUB_HEAD_REF` so it can fetch the submodules and build the docs. This change checks out `gravitational/teleport` using `actions/checkout` instead, then copies the `teleport` clone into the `content` directory of the `docs` clone. This way, we don't need to extract a branch name, and can perform multiple checks on the `teleport` clone, e.g., the Vale linter when we add it to `Lint (Docs)`.
ptgott
force-pushed
the
paul.gottschling/2024-11-12-no-submodules
branch
from
637602f to
9c5cb89
Compare
ptgott
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
zmb3
approved these changes
Nov 12, 2024
ptgott
added
the
no-changelog
|
@mmcallister Checking to see if this looks okay to you. Thanks! |
mmcallister
approved these changes
Nov 13, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious and
mvbrock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Lint (Docs)configures git submodules forgravitational/teleportwithin agravitational/docsclone based on the value of$GITHUB_REFor$GITHUB_HEAD_REFso it can fetch the submodules and build the docs.This change checks out
gravitational/teleportusingactions/checkoutinstead, then copies theteleportclone into thecontentdirectory of thedocsclone. This way, we don't need to extract a branch name, and can perform multiple checks on theteleportclone, e.g., the Vale linter when we add it toLint (Docs).