Add xterm/image-addon to web terminal #48780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the terminal in the web UI to "pretty print" images based on the supported protocols (SIXEL and IIP)
zmb3
approved these changes
Nov 12, 2024
kimlisa
approved these changes
Nov 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
avatus
added a commit
that referenced
this pull request
Nov 12, 2024
This was referenced Nov 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* [v16] Add xterm/image-addon to web terminal Backport #48780 * [v16] Add wasm to content security policy for web ssh terminal
ravicious
reviewed
Nov 18, 2024
| "@xterm/addon-canvas": "^0.7.0", | ||
| "@xterm/addon-fit": "^0.10.0", | ||
| "@xterm/addon-image": "^0.8.0", |
There was a problem hiding this comment.
Did you have a chance to look into how this works?
In theory, it's something that would be nice to have in Connect too. But it also would be the first time we render 3rd-party content within Connect. If it leads to an RCE, our security posture is definitely much worse than that of a regular web browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the terminal in the web UI to "pretty print" images based on the supported protocols (SIXEL and IIP)
changelog: The web terminal now supports SIXEL and IIP image protocols.