Properly propagate private key for azure app #48550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
greedy52
force-pushed
the
STeve/48522_fix_azure_cli_private_key
branch
from
9ee501b to
b264cf7
Compare
greedy52
changed the title
github-actions
bot
added
size/sm
tsh
Tener
approved these changes
Nov 8, 2024
gabrielcorado
approved these changes
Nov 8, 2024
greedy52
added
the
no-changelog
|
Friendly ping @nklaassen and @fspmarshall |
nklaassen
reviewed
Nov 12, 2024
fspmarshall
approved these changes
Nov 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kopiczko
nklaassen
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48522
Azure middleware needs to use a private key to sign JWT and the server verifies the JWT using the App TLS cert. This is broken after the App TLS cert uses its own key instead of the core one.