Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 builds to Drone #4639

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Add arm64 builds to Drone #4639

merged 1 commit into from
Oct 29, 2020

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented Oct 24, 2020

Uses an a1 machine in AWS I set up a while ago to build arm64 Teleport binaries for Linux.

$ file ./teleport/teleport
./teleport/teleport: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, BuildID[sha
1]=ee9a95dfd2f09d6e25b064bfda88d97c39423089, for GNU/Linux 3.7.0, stripped

$ ./teleport/teleport version
Teleport v5.0.0-dev.15 git:v5.0.0-dev.15-0-g96583a89c go1.14.4

Needs some accompanying changes in Houston to display downloads to the public as well.

Fixes #1812

@webvictim webvictim self-assigned this Oct 24, 2020
@webvictim webvictim force-pushed the gus/arm64 branch 2 times, most recently from 9f8e688 to fd9c83d Compare October 24, 2020 20:07
@webvictim webvictim marked this pull request as ready for review October 24, 2020 20:09
@webvictim webvictim requested a review from benarent October 26, 2020 12:23
@benarent
Copy link
Contributor

benarent commented Oct 26, 2020

Will this just build the latest, or will we also build for 4.0,4.1,4.2,4.3

@webvictim
Copy link
Contributor Author

This PR is only going into master currently so it'd start with the next release branch we cut (5.0.0)

We could backport it to 4.4 easily so we'd get arm64 from 4.4.2 onwards if we wanted.

4.3 is trickier but we could cut and make a specific 4.3.8 release to add arm64 if we wanted.

Anything before that would require changes to Jenkins so not happening.

@benarent
Copy link
Contributor

Thanks for the clarification Gus, for now let's just back port to 4.3 ( as we've a customer request for this ) .

Copy link
Contributor

@benarent benarent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest, What size A1 instance are we using and how long does it take?

@webvictim
Copy link
Contributor Author

https://drone.gravitational.io/gravitational/teleport/2663/1/3

It's currently an a1.large so 2 vCPUs, 4GB RAM. The build stage took 4m17s. We could probably go down to an a1.medium to halve the cost if we wanted - AMI builds take way longer than artifacts currently.

@MiLk
Copy link

MiLk commented Oct 28, 2020

Thanks for the work here !

If cost is an issue, wouldn't a t4g instance be better?

@webvictim
Copy link
Contributor Author

@awly @r0mant @russjones Ping for CODEOWNERS approval please.

@benarent benarent linked an issue Oct 28, 2020 that may be closed by this pull request
@webvictim webvictim requested a review from r0mant as a code owner October 29, 2020 02:14
@webvictim webvictim merged commit 9c0d2bd into master Oct 29, 2020
@webvictim webvictim deleted the gus/arm64 branch October 29, 2020 02:23
webvictim added a commit that referenced this pull request Oct 29, 2020
webvictim added a commit that referenced this pull request Oct 29, 2020
@webvictim webvictim restored the gus/arm64 branch October 29, 2020 02:36
@webvictim webvictim deleted the gus/arm64 branch October 29, 2020 02:37
@webvictim
Copy link
Contributor Author

We're not super concerned about the cost for now - fast builds are more important. Will keep notes for the future though :)

webvictim added a commit that referenced this pull request Oct 30, 2020
webvictim added a commit that referenced this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM/ARM64 packages arm64 release binaries
4 participants