bump github.com/microsoftgraph/msgraph-sdk-go to v1.46.0
#44205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version `v1.44.0`-`v1.45.0` were recall because they included breaking changes into constructures names microsoftgraph/msgraph-sdk-go#738 that cause teleport to fail builds when using `go.work`. This PR bumps the version to all affected go.mod files. Signed-off-by: Tiago Silva <[email protected]>
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
tigrato
added
the
no-changelog
|
We need to ensure we never update |
marcoandredinis
approved these changes
Jul 15, 2024
rosstimothy
approved these changes
Jul 15, 2024
public-teleport-github-review-bot
bot
removed request for
codingllama and
hugoShaka
codingllama
reviewed
Jul 15, 2024
| @@ -146,7 +146,7 @@ require ( | |||
| github.com/mdlayher/netlink v1.7.2 | |||
| github.com/microsoft/go-mssqldb v1.7.2 // replaced | |||
| github.com/microsoft/kiota-authentication-azure-go v1.0.2 | |||
| github.com/microsoftgraph/msgraph-sdk-go v1.43.0 | |||
| github.com/microsoftgraph/msgraph-sdk-go v1.46.0 | |||
There was a problem hiding this comment.
Thanks. I noticed msgraph-sdk-go was weird in our last update batch and kept it at v1.43.0 (#43828 (comment)), but apparently some of the indirects in other modules skipped. I figured a fix would land at some point.
codingllama
approved these changes
Jul 15, 2024
|
It looks like you need to tidy the root module. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
v1.44.0tov1.45.0were recalled due to breaking changes in constructor names, as detailed in this pull request. These changes caused build failures for Teleport when usinggo.work.This pull request updates the version in all affected go.mod files.