Remove U2F fallback from client tools #43133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/remove_u2f
branch
2 times, most recently
from
9451a73 to
4c96631
Compare
rosstimothy
added
backport/branch/v14
no-changelog
codingllama
approved these changes
Jun 17, 2024
codingllama
changed the title
|
Re-phrased title, as technically U2F support still exists, it's the U2F "native" fallback code that we are deleting. |
zmb3
approved these changes
Jun 17, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rudream
rosstimothy
force-pushed
the
tross/remove_u2f
branch
from
4c96631 to
672ef3e
Compare
codingllama
reviewed
Jun 17, 2024
codingllama
reviewed
Jun 17, 2024
rosstimothy
force-pushed
the
tross/remove_u2f
branch
from
672ef3e to
5f44c6e
Compare
codingllama
approved these changes
Jun 17, 2024
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of github.com/flynn/u2f and github.com/flynn/hid from lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled. In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result. Updates #43112.
rosstimothy
force-pushed
the
tross/remove_u2f
branch
from
5f44c6e to
2b99d5b
Compare
|
@rosstimothy See the table below for backport results.
|
|
This makes it so that tsh needs to be build with FIDO2 for Webauthn to work on macOS, otherwise you get some variant of "hardware device MFA not supported by your platform, please register an OTP device". |
rosstimothy
added a commit
that referenced
this pull request
Jun 18, 2024
#43133 removed the fallback to U2F that this target was relying on to exercise code that required 2FA. The build tags set in `test-go-flaky` now include LIBFIDO2_TEST_TAG in a similar manner to other targets that are passing in CI without issue (`lint-go`, `test-go-unit`).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
#43133 removed the fallback to U2F that this target was relying on to exercise code that required 2FA. The build tags set in `test-go-flaky` now include LIBFIDO2_TEST_TAG in a similar manner to other targets that are passing in CI without issue (`lint-go`, `test-go-unit`).
This is intended, although in hindsight we should have communicated better. Tim and I are talking about ways to improve our developer experience around this. |
rosstimothy
added a commit
that referenced
this pull request
Jun 20, 2024
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of github.com/flynn/u2f and github.com/flynn/hid from lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled. In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result. Updates #43112.
rosstimothy
added a commit
that referenced
this pull request
Jun 20, 2024
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of github.com/flynn/u2f and github.com/flynn/hid from lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled. In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result. Updates #43112.
rosstimothy
added a commit
that referenced
this pull request
Jun 20, 2024
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of github.com/flynn/u2f and github.com/flynn/hid from lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled. In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result. Updates #43112.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of github.com/flynn/u2f and github.com/flynn/hid from lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled. In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result. Updates #43112.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of github.com/flynn/u2f and github.com/flynn/hid from lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled. In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result. Updates #43112.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of github.com/flynn/u2f and github.com/flynn/hid from lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled. In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result. Updates #43112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
U2F support was deprecated in favor of WebAuthn many releases ago, however, not all references were removed when working on #10375. This eliminates the last remaining inclusions of
github.com/flynn/u2fandgithub.aaakk.us.kg/flynn/hidfrom lib/client and drops all support of falling back to U2F if client tools are not built with FIDO2 enabled.In practice, this should only cause problems for people building tsh/tctl locally without setting the correct build flags. All release artifacts published should already be built with the appropriate flags and not cause any issues as a result.
Updates #43112.