Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bypass for dependabot on dependency-review check #35066

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

reedloden
Copy link
Contributor

The bypass if for dependabot PRs added in #19745 is failing dependency-review due to this workflow effectively just proxying to another workflow in shared-workflows. This is causing the workflow to not run at all, and since it's required, it's causing dependabot PRs to not pass status checks. Remove the bypass for now to make checks pass again.

The bypass `if` for dependabot PRs added in #19745 is failing `dependency-review` due
to this workflow effectively just proxying to another workflow in `shared-workflows`.
This is causing the workflow to not run at all, and since it's required, it's causing
dependabot PRs to not pass status checks. Remove the bypass for now to make checks
pass again.
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@reedloden reedloden added backport/branch/v12 backport/branch/v13 backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry labels Nov 28, 2023
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from jimbishopp November 28, 2023 18:34
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Reed!

@reedloden reedloden added this pull request to the merge queue Nov 28, 2023
Merged via the queue into master with commit 0d4f6d1 Nov 28, 2023
35 of 36 checks passed
@reedloden reedloden deleted the reed/dep-rev-dont-ignore-dependabot branch November 28, 2023 19:25
@public-teleport-github-review-bot

@reedloden See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v13 backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants