Update Electron to v26 #30679
Merged
Update Electron to v26 #30679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a tag build? |
|
No, I don't. I only did a local build, which I ran. |
|
Ah, I keep forgetting that this is something we can do. So yeah, thorough testing is not necessary, but I'd still run a tag build just to make sure that this change won't block the alpha releases. |
|
Build in progress! https://drone.platform.teleport.sh/gravitational/teleport/27397 |
ravicious
approved these changes
Aug 18, 2023
zmb3
approved these changes
Aug 18, 2023
|
The build passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it quickly on macOS and didn't find any issues. In the release notes I also don't see any changes that affect us.
This should be backported after we finish the test plan.