fix orphane processes, fixes #191 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
added a commit
that referenced
this pull request
Mar 3, 2016
fix orphane processes, fixes #191
alex-kovoy
added a commit
that referenced
this pull request
Nov 12, 2020
e11fb6f Safari fixes (#192) gravitational/webapps@e11fb6f [source: -w master] [target: -t master]
alex-kovoy
added a commit
that referenced
this pull request
Nov 12, 2020
e11fb6f Safari fixes (#192) gravitational/webapps@e11fb6f [source: -w master] [target: -t master]
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
* Safari fixes
nick-inkeep
pushed a commit
to nick-inkeep/teleport-docs
that referenced
this pull request
Jun 20, 2023
Closes gravitational#191 The `markdown-lint` script includes all files in `docs/pages/includes`. The script also processes partial inclusion expressions within docs pages, then lints those pages. This means that partials are linted at least twice: once on their own and for every time they are included in a docs page. The first lint pass for each partial usually works as expected. However, there is an issue if a partial includes a default parameter value (gravitational#171), like this: ``` {{ var="default value" }} Here is a variable with a {{ var }}. ``` When a page includes this partial, the docs engine removes the first line before inserting the resolved text. As a result, partials with default parameters render as expected and pass the linter within their including pages. But when we run the `markdown-lint` script, and the linter checks the partial on its own, the first line remains in the partial. This causes the linter to return an error. This change edits the `markdown-lint` script to ignore files within `docs/pages/includes`. This will allow us to use partials with default parameter values without them breaking CI.
nick-inkeep
pushed a commit
to nick-inkeep/teleport-docs
that referenced
this pull request
Jun 20, 2023
The intention in gravitational#192 was to ignore directories containing partials when linting, since (a) these partials would be included within docs pages when linting anyway, and (b) the linter returns errors when encountering default parameter assignments within partials. The change in gravitational#192 ignored includes in 'content/*/docs/pages/includes/*'. However, in the `gravitational/teleport` CI container, docs content is mounted to `content/`, without a version directory. This means that default parameter assignments in `gravitational/teleport` partials still fail the linter, since the partial URL would be something like `content/docs/pages/includes/add-role-to-user.mdx`. This change makes the pattern for ignoring partials more general so it matches any file path with an `/includes/` segment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.