[v9] db access denied error message improvement #17857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix matchers not being printed in err message * Add helpful message when access is denied to db connect * Add test for converting command errors * Simplify error message when access to db is denied * Update lib/client/db/dbcmd/dbcmd_test.go Co-authored-by: Marek Smoliński <[email protected]> * Remove unnecessary cmd.Run in test * Fix import order * Add full error to message * Fix formatting of github suggestion * Add troubleshooting link * Update troubleshooting link to use subheading Co-authored-by: Marek Smoliński <[email protected]>
GavinFrazar
commented
Oct 26, 2022
Comment on lines
+628
to
+633
| c.exe = &fakeExec{ | ||
| commandPathBehavior: forceBasePath, | ||
| execOutput: map[string][]byte{ | ||
| tt.wantBin: tt.stderr, | ||
| }, | ||
| } |
There was a problem hiding this comment.
I had to update this test to use c.exe instead of c.options.exe since exe was moved after v9 and not backported, but it does not affect this PR.
smallinsky
approved these changes
Oct 27, 2022
jakule
approved these changes
Oct 27, 2022
…essage_improvement
GavinFrazar
deleted the
gavinfrazar/v9_db_access_denied_error_message_improvement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #16228 to branch/v9