Remove SHA-1 signed keys #16912
Closed
Remove SHA-1 signed keys #16912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jakule
force-pushed
the
jakule/remove-sha-1
branch
from
6e3166b to
2a2226e
Compare
github-actions
bot
added
machine-id
tsh
tigrato
approved these changes
Oct 3, 2022
r0mant
reviewed
Oct 4, 2022
lib/config/openssh.go
Outdated
| UserKnownHostsFile "{{ $dot.KnownHostsPath }}" | ||
| IdentityFile "{{ $dot.IdentityFilePath }}" | ||
| CertificateFile "{{ $dot.CertificateFilePath }}"{{- if $dot.NewerHostKeyAlgorithmsSupported }} | ||
| HostKeyAlgorithms [email protected],[email protected]{{- else }} |
There was a problem hiding this comment.
Do we need to include these explicitly? Can't just not set host key algos in this case?
There was a problem hiding this comment.
No, because of 3rd party libraries that I don't want to mention here. I changed the logic to work with SHA-2 and SHA-1 if the first one is not supported.
jakule
force-pushed
the
jakule/remove-sha-1
branch
from
5d44945 to
fb29329
Compare
r0mant
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
lgtm but let's please wait for @timothyb89 to review as well
Co-authored-by: Roman Tkachenko <[email protected]>
timothyb89
approved these changes
Oct 5, 2022
|
I converted this PR back to a draft as we found out that crypto SSH patch breaks older OpenSSH clients. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches Go crypto library to our fork that supports extension negotiation (RFC 8308).
It also removes
PubkeyAcceptedAlgorithms [email protected]from the SSH config file as this option is no longer needed.I also refactored the SSH config generation logic as we had to separate generators. One for
tsh configand the second fortbotthat were doing the same thing.Closes #10918
Closes #15149
Closes #15633