Alex/fix tests #167
Closed
Alex/fix tests #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexlyulkov this branch can not be merged - it has some conflicts, can you resolve the conflicts? |
| GetCertAuthorities(caType services.CertAuthType) ([]*services.CertAuthority, error) | ||
| } | ||
|
|
||
| type retryingClient struct { |
There was a problem hiding this comment.
struct RetryingTransport {
*http.Transport
Retries int
}
func (t *RetryingTransport) RoundTrip() (*http.Response, error) {
for ... retries {
t.Transport.Roundtrip()
}
} roundtrip.NewClient(..., roundtrip.Transport(&RetryingTransport))
nick-inkeep
pushed a commit
to nick-inkeep/teleport-docs
that referenced
this pull request
Jun 20, 2023
Fixes gravitational#167 `handlePartialLink` currently hardcodes `docs/pages` as the location of all docs pages, and uses this file path segment to construct the absolute path of the MDX file that includes a partial. This change adds the root directory of all partials as a parameter of `handlePartialLink` and uses that instead. Since this root directory is configurable outside `remark-includes`, this change lets us add unit tests for `handlePartialLink`. This change also handles relative path resolution for image and link definition URLs. The current version of `handlePartialLink` only handles links paths. As a result, this renames `handlePartialLink` to `handleURLPath`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed tsh tests,
Added auth client with retries,
Changed ports in tests