[v9] Trace ssh sessions #15615
Merged
[v9] Trace ssh sessions #15615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a wrapper around `ssh.Session` which injects tracing context in a similar manner to the `ssh.Client` wrapper. All usages of `ssh.Session` have now been replaced and have the appropriate `context.Context` passed along Part of #12241
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| defer span.End() | ||
|
|
||
| s.wrapper.addContext(ctx, request) | ||
| return s.Session.Start(cmd) |
Check failure
Code scanning / CodeQL
Command built from user-controlled sources
| defer span.End() | ||
|
|
||
| s.wrapper.addContext(ctx, request) | ||
| return s.Session.Run(cmd) |
Check failure
Code scanning / CodeQL
Command built from user-controlled sources
github-actions
bot
added
backport
tsh
ryanclark
approved these changes
Aug 22, 2022
|
friendly ping @fspmarshall |
fspmarshall
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #14966 to branch/v9