Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Prevent forwarding traces to servers which don't support tracing #15479

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

rosstimothy
Copy link
Contributor

Backports #14281 to branch/v9

Verified

This commit was signed with the committer’s verified signature.
)

* Prevent forwarding traces to servers which don't support tracing

Tracing clients can detect if a server doesn't support tracing by
checking for a trace.NotImplented error in response to an
UploadTraces request. Since the grpc.Conn used by the client is
likely to be bound to that server for the duration of its life
it doesn't make sense to keep trying to forward traces. Instead
the client now remembers that a server doesn't support tracing
and will drop any spans.

Part of #12241
@rosstimothy rosstimothy force-pushed the tross/backport-14281-branch/v9 branch from d638333 to 553517a Compare August 12, 2022 15:19
@rosstimothy rosstimothy marked this pull request as ready for review August 12, 2022 16:36
@github-actions github-actions bot requested review from espadolini and Tener August 12, 2022 16:36
@github-actions github-actions bot removed the request for review from espadolini August 15, 2022 20:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@rosstimothy rosstimothy enabled auto-merge (squash) August 16, 2022 14:31
@rosstimothy rosstimothy merged commit 183df65 into branch/v9 Aug 16, 2022
@zmb3 zmb3 deleted the tross/backport-14281-branch/v9 branch September 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants