Remove update verb requirement when creating Tokens
#14506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
approved these changes
Jul 15, 2022
No, there's another method which only requires the |
marcoandredinis
force-pushed
the
marco/grpc_add_create_token_api
branch
from
3633f76 to
29f7ee3
Compare
marcoandredinis
force-pushed
the
marco/grpc_add_create_token_api
branch
2 times, most recently
from
9d287fb to
3494320
Compare
ibeckermayer
approved these changes
Jul 18, 2022
marcoandredinis
force-pushed
the
marco/grpc_add_create_token_api
branch
from
3494320 to
29f1b3c
Compare
The used method to create a token in the UI is UpsertToken. This method requires Create and Update verbs. It shouldn't be necessary to have the Update verb - we are only creating and not changing anything. This PR adds - a new method - CreateToken - which only requires the Create verb. - apiserver uses this method to issue a new token
Co-authored-by: Isaiah Becker-Mayer <[email protected]>
marcoandredinis
force-pushed
the
marco/grpc_add_create_token_api
branch
from
be7d016 to
c21edb6
Compare
|
@marcoandredinis See the table below for backport results.
|
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Jul 19, 2022
The used method to create a token in the UI is UpsertToken. This method requires Create and Update verbs. It shouldn't be necessary to have the Update verb - we are only creating and not changing anything. This PR adds - a new method - CreateToken - which only requires the Create verb. - apiserver uses this method to issue a new token Co-authored-by: Isaiah Becker-Mayer <[email protected]>
marcoandredinis
added a commit
that referenced
this pull request
Jul 19, 2022
…14624) Remove `update` verb requirement when creating Tokens (#14506) The used method to create a token in the UI is UpsertToken. This method requires Create and Update verbs. It shouldn't be necessary to have the Update verb - we are only creating and not changing anything. This PR adds - a new method - CreateToken - which only requires the Create verb. - apiserver uses this method to issue a new token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The used method to create a token in the UI is UpsertToken.
This method requires Create and Update verbs.
It shouldn't be necessary to have the Update verb - we are only creating
and not changing anything.
This PR adds
Demo
User with role that doesn't have
updateontokens:Can successfully generate tokens:
Fixes #13218