Require user interaction to find Touch ID credentials #14448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
force-pushed
the
codingllama/touchid-shared-lacontext
branch
from
9294b9f to
0c14781
Compare
|
After doing more testing I think I'll have to change some parts of this PR. I'll let you know when it's good to go. |
|
Replaced by #14492. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require user interaction to find credentials, as a preparation for the Touch ID credential picker. No user-visible changes are introduced in this PR, even though program behavior is slightly different.
To avoid double-prompting users during Touch ID authentication we have to set a grace period in the underlying LAContext and share it between functions. Note that FindCredentials (native) uses the LAContext explicitly, whereas Authenticate (native) uses it through the SecItemCopyMatching query dictionary.
A new HasCredentials check is introduced so we keep the current behavior of failing without user interaction if no Touch ID keys are present. This is necessary to keep the
tshUX smooth.#13901