Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TestAppServersHA. #14032

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fixed TestAppServersHA. #14032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions integration/app_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ func (p *pack) appServersHA(t *testing.T) {
// Stop all root app servers.
for i, appServer := range info.appServers {
require.NoError(t, appServer.Close())
require.NoError(t, appServer.Wait())

if i == len(info.appServers)-1 {
// fails only when the last one is closed.
Expand All @@ -619,6 +620,7 @@ func (p *pack) appServersHA(t *testing.T) {

for _, appServer := range servers {
require.NoError(t, appServer.Close())
require.NoError(t, appServer.Wait())

// Everytime an app server stops we issue a request to
// guarantee that the requests are going to be resolved by
Expand Down