lib/services/role CurrentUserRoleGetter: Fix comment #13923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
approved these changes
Jul 11, 2022
|
Closing as the comment already got updated in #14092. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by @GavinFrazar under my PR (#13877 (comment)). The comment refers to a function that I since renamed.
Just before finishing my work yesterday I got too excited by seeing the CI pass for that PR. I went ahead and merged it only to realize that I had set its base to another PR (#13625).
To avoid making even more mess I created this PR which I'm going to backport to v10 too after #13625 gets in.