Add Machine ID enterprise license enforcement #13914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mild caveat that I've so far opted to not include a license check on bot renewals (only create and onboard). I figure that'll cover the 90% case without necessarily breaking people's infrastructure and am a bit wary of adding license checks in Tested with OSS (always enabled) and Enterprise (with + without the flag). |
timothyb89
changed the title
This adds two checks to Machine ID for license enforcement: one on initial bot create, and another on join.
timothyb89
force-pushed
the
timothyb89/machine-id-license-enforcement
branch
from
4b59286 to
356407b
Compare
zmb3
approved these changes
Jun 28, 2022
|
@timothyb89 See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two checks to Machine ID for license enforcement: one on initial bot create, and another on join.
Fixes #12915