Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop v from macOS tsh installer version number #13896

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Jun 27, 2022

Drop the v from the tsh installer version number, which was inadvertently changed by #12751. Makes the installer reappear as a download option in Houston.

Note that the final .app name still has the v. Ie:

  • tsh-10.0.0-dev.pkg (installer)
  • tsh-10.0.0-dev.pkg.sha256 (installer hash)
  • tsh-v10.0.0-dev.app (Application package)

@codingllama
Copy link
Contributor Author

FYI @zmb3 @r0mant

@github-actions github-actions bot requested review from atburke and espadolini June 27, 2022 19:07
@zmb3
Copy link
Collaborator

zmb3 commented Jun 27, 2022

Does the app package show up in houston correctly?

@codingllama
Copy link
Contributor Author

The application package doesn't show in Houston, it's what gets installed into /Applications. I'm just calling attention to the fact that the installer and the app it installs have slightly different names, so I can change the app name if we think it's best.

Copy link
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions for or against the v in the app bundle name

@codingllama codingllama force-pushed the codingllama/installer-drop-v branch from 008b807 to d5d8c63 Compare June 27, 2022 19:45
@codingllama codingllama force-pushed the codingllama/installer-drop-v branch from d5d8c63 to ae81ec7 Compare June 27, 2022 20:26
@codingllama codingllama enabled auto-merge (squash) June 27, 2022 20:26
@codingllama codingllama force-pushed the codingllama/installer-drop-v branch from ae81ec7 to 569b42e Compare June 28, 2022 13:38
@codingllama codingllama merged commit c206824 into master Jun 28, 2022
@github-actions
Copy link

@codingllama See the table below for backport results.

Branch Result
branch/v10 Create PR

@codingllama codingllama deleted the codingllama/installer-drop-v branch June 28, 2022 14:52
codingllama added a commit that referenced this pull request Jun 29, 2022
Drop the `v` from the tsh installer version number, which was inadvertently
changed by #12751. Makes the installer reappear as a download option in Houston.

Note that the final .app name still has the `v`. Ie:

* tsh-10.0.0-dev.pkg (installer) tsh-10.0.0-dev.pkg.sha256 (installer hash)
* tsh-v10.0.0-dev.app (Application package)

Backport #13896 to branch/v10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants