-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop v
from macOS tsh installer version number
#13896
Conversation
Does the app package show up in houston correctly? |
The application package doesn't show in Houston, it's what gets installed into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinions for or against the v
in the app bundle name
008b807
to
d5d8c63
Compare
d5d8c63
to
ae81ec7
Compare
ae81ec7
to
569b42e
Compare
@codingllama See the table below for backport results.
|
Drop the `v` from the tsh installer version number, which was inadvertently changed by #12751. Makes the installer reappear as a download option in Houston. Note that the final .app name still has the `v`. Ie: * tsh-10.0.0-dev.pkg (installer) tsh-10.0.0-dev.pkg.sha256 (installer hash) * tsh-v10.0.0-dev.app (Application package) Backport #13896 to branch/v10
Drop the
v
from the tsh installer version number, which was inadvertently changed by #12751. Makes the installer reappear as a download option in Houston.Note that the final .app name still has the
v
. Ie: