Add error check before handle_bitmap
#13828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
approved these changes
Jun 23, 2022
zmb3
reviewed
Jun 24, 2022
zmb3
approved these changes
Jun 24, 2022
|
@ibeckermayer See the table below for backport results.
|
|
The branch/v9 backport depends on #13707 |
ibeckermayer
pushed a commit
that referenced
this pull request
Jun 30, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Jun 30, 2022
Add error check before `handle_bitmap` (#13828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback
cbwhich callshandle_bitmapcan be called multiple times per call tordp_client.read(cb), if thePayloadof the call contains multiple messages. This change adds a check before the section that callshandle_bitmap, which ensures that in such a case, if one call tohandle_bitmapfails, no additional calls are made.I'll tentatively say this fixes #13723, which can be consulted for more on how
handle_bitmapcan get called repeatedly. There remains some unknown change that's causing this behavior to manifest onbranch/v10but notbranch/v9, but I don't think figuring out precisely what it is is high priority at this moment (thoughts @zmb3 ?)