Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Add context to "tsh ls" in docs #13818

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Jun 23, 2022

Backports #12583

  • Add context to "tsh ls" in docs

Fixes #7051

  • Create a partial for how the Teleport Auth Service filters Nodes
    based on user roles/logins in response to queries.
  • Add the partial to provide context for example commands that include
    "tsh ls".
  • Make our existing text on Teleport's authorization checks clearer
    by enumerating the checks in the order they are executed in
    services.RoleSet.CheckAccess.

Note that this does not change guides that instruct the user to create
a new user and role, since a user following these guides will see the
correct "tsh ls" output.

  • Respond to PR feedback

@ptgott
Copy link
Contributor Author

ptgott commented Jun 24, 2022

I won't be able to merge this until #13805 is merged

@ptgott ptgott force-pushed the paul.gottschling/12583-bp-v9 branch from 0acec81 to 1d62096 Compare July 7, 2022 19:57
@ptgott ptgott enabled auto-merge (squash) July 7, 2022 20:33
Backports #12583

* Add context to "tsh ls" in docs

Fixes #7051

- Create a partial for how the Teleport Auth Service filters Nodes
  based on user roles/logins in response to queries.
- Add the partial to provide context for example commands that include
  "tsh ls".
- Make our existing text on Teleport's authorization checks clearer
  by enumerating the checks in the order they are executed in
  services.RoleSet.CheckAccess.

Note that this does not change guides that instruct the user to create
a new user and role, since a user following these guides will see the
correct "tsh ls" output.

* Respond to PR feedback
@ptgott ptgott force-pushed the paul.gottschling/12583-bp-v9 branch from 1d62096 to 7654aa5 Compare July 7, 2022 20:33
@ptgott ptgott merged commit 40c6b09 into branch/v9 Jul 7, 2022
@zmb3 zmb3 deleted the paul.gottschling/12583-bp-v9 branch September 9, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants