Bump go.mod to use Go 1.18 #13771
Merged
Bump go.mod to use Go 1.18 #13771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedloden
force-pushed
the
reed/bump-go-mod-go1.8
branch
from
0fabf46 to
6d4e536
Compare
reedloden
force-pushed
the
reed/bump-go-mod-go1.8
branch
from
6d4e536 to
4eef03c
Compare
jakule
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
@reedloden Just to confirm. You're bumping up the version only on master or you're also going to do it on v10?
I defer to the core team as to what you all would want. For my purposes for fuzzing, I am only caring about master. But might be worthwhile to do v10 as well? Let me know. |
|
We can keep the fuzz tests in master only for now, but let's put the 1.18 directive in v10 as well. This will prevent a new change that leverages 1.18 features from failing when it is backported |
reedloden
force-pushed
the
reed/bump-go-mod-go1.8
branch
from
4eef03c to
b63f702
Compare
zmb3
approved these changes
Jun 23, 2022
reedloden
force-pushed
the
reed/bump-go-mod-go1.8
branch
2 times, most recently
from
fa21b12 to
619fa2d
Compare
zmb3
reviewed
Jun 23, 2022
reedloden
force-pushed
the
reed/bump-go-mod-go1.8
branch
from
619fa2d to
1770160
Compare
zmb3
approved these changes
Jun 24, 2022
r0mant
approved these changes
Jun 28, 2022
reedloden
force-pushed
the
reed/bump-go-mod-go1.8
branch
from
1770160 to
7c285bf
Compare
We're now using Go 1.18 features (native fuzzing in #13473), which means we need to accurately state that we require Go 1.18 in our go.mod. Also, run `go mod tidy`.
reedloden
force-pushed
the
reed/bump-go-mod-go1.8
branch
from
7c285bf to
0dd5a99
Compare
reedloden
added a commit
that referenced
this pull request
Jun 29, 2022
… Go 1.18 Missed two CI-related go.mod files in #13771, so bumping them to keep everything consistent.
Merged
reedloden
added a commit
that referenced
this pull request
Jul 1, 2022
… Go 1.18 Missed two CI-related go.mod files in #13771, so bumping them to keep everything consistent.
reedloden
added a commit
that referenced
this pull request
Jul 13, 2022
… Go 1.18 Missed two CI-related go.mod files in #13771, so bumping them to keep everything consistent.
reedloden
added a commit
that referenced
this pull request
Jul 14, 2022
… Go 1.18 Missed two CI-related go.mod files in #13771, so bumping them to keep everything consistent.
reedloden
added a commit
that referenced
this pull request
Aug 2, 2022
… Go 1.18 Missed two CI-related go.mod files in #13771, so bumping them to keep everything consistent.
reedloden
added a commit
that referenced
this pull request
Aug 4, 2022
… Go 1.18 Missed two CI-related go.mod files in #13771, so bumping them to keep everything consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now using Go 1.18 features (native fuzzing in #13473), which means we need to accurately state that we require Go 1.18 in our go.mod.