Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add networking with TLS routing #13762

Merged
merged 4 commits into from
Jul 3, 2022
Merged

Add networking with TLS routing #13762

merged 4 commits into from
Jul 3, 2022

Conversation

klizhentas
Copy link
Contributor

@klizhentas klizhentas commented Jun 22, 2022 •
edited by zmb3
Loading

Fixes #13751

@klizhentas klizhentas requested review from zmb3, r0mant and ptgott June 22, 2022 19:38
@klizhentas
Copy link
Contributor Author

@zmb3 @r0mant is the new section accurate from the perspective of Desktop access and K8s access? I've noticed two exra ports, but dont' recall if TLS routing routes properly without those up.

@github-actions github-actions bot requested a review from xinding33 June 22, 2022 19:39
@klizhentas klizhentas requested review from strideynet and wadells June 23, 2022 02:56
strideynet
strideynet approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@zmb3
Copy link
Collaborator

zmb3 commented Jun 23, 2022

Port 3028 for desktop access should be present in both lists as windows desktop service is always going to have a listen port when you're not using iot mode.

TLS routing is a feature of the proxy service. Desktop access connections to the proxy already come in on the proxy https port because you have to use the web UI to start a Session.

@zmb3 zmb3 changed the title Add networking with TLS routing, fixes #13751 Add networking with TLS routing Jun 24, 2022
@klizhentas klizhentas enabled auto-merge (squash) July 2, 2022 21:34
@klizhentas klizhentas merged commit 0cf227d into master Jul 3, 2022
klizhentas added a commit that referenced this pull request Jul 3, 2022
@klizhentas
Add networking with TLS routing (#13762)
da95fa2 
* Add networking with TLS routing, fixes #13751
klizhentas added a commit that referenced this pull request Jul 4, 2022
@klizhentas
[v10] Add networking with TLS routing (#13762) (#14070)
bd37343 
Add networking with TLS routing (#13762)

* Add networking with TLS routing, fixes #13751
@webvictim webvictim mentioned this pull request Jul 12, 2022
Closed
@zmb3 zmb3 deleted the sasha/networking branch September 9, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strideynet strideynet strideynet approved these changes

@r0mant r0mant r0mant approved these changes

@zmb3 zmb3 Awaiting requested review from zmb3

@ptgott ptgott Awaiting requested review from ptgott

@xinding33 xinding33 Awaiting requested review from xinding33

@wadells wadells Awaiting requested review from wadells

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Networking section is incomplete
5 participants
@klizhentas @zmb3 @wadells @r0mant @strideynet