Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for PagerDuty Helm chart #13729

Merged
merged 7 commits into from
Aug 31, 2022

Conversation

kbence
Copy link
Contributor

@kbence kbence commented Jun 22, 2022

It includes an updated guide and the reference of the new Helm chart.

Related to https://github.com/gravitational/teleport-private/issues/140

@logand22
Copy link
Contributor

It'd be awesome if docs PRs created a temporary copy of goteleport.com such that I could view the rendered version automatically. When the PR was merged / closed it would spin down the example.

Copy link
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

Copy link
Contributor

@logand22 logand22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good. I haven't checked the formatting however.

docs/pages/enterprise/workflow/ssh-approval-pagerduty.mdx Outdated Show resolved Hide resolved
docs/config.json Outdated Show resolved Hide resolved
@kbence kbence force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from 416777c to d072731 Compare July 5, 2022 10:59
@russjones
Copy link
Contributor

@kbence Can you make the changes requested by @zmb3 and/or @ptgott to this PR so we can merge it.

This task is not complete until documentation is available and customers can benefit from the Teleport Plugins Helm Charts.

@ptgott
Copy link
Contributor

ptgott commented Aug 17, 2022

@kbence PR #14576 makes a lot of changes to the PagerDuty plugin guide. Once that's merged, I can edit the configuration section to include instructions for the Helm chart. Rather than using a Details box after the main configuration instructions, I suggest we use the dropdown functionality in the Tabs component to add separate sets of tabs for using an executable and using the Helm chart. Each set would include one TabItem for connecting to the Proxy and one TabItem for connecting to the Auth Service.

@kbence kbence force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from 58b3f08 to b0d39e6 Compare August 18, 2022 14:50
@kbence kbence force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from 2213e3e to f68ddb3 Compare August 22, 2022 13:45
@kbence kbence requested a review from ptgott August 22, 2022 13:49
@kbence kbence enabled auto-merge (squash) August 22, 2022 13:49
@ptgott
Copy link
Contributor

ptgott commented Aug 23, 2022

I'm going to fix the conflicts since they're due to my PR (#15357).

@ptgott ptgott force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from 145f116 to 6d1b809 Compare August 23, 2022 15:06
@kbence kbence requested a review from zmb3 August 24, 2022 10:36
@kbence kbence force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from ebef339 to 3ab92a7 Compare August 29, 2022 16:01
@kbence kbence force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from 20d02f6 to 41349ce Compare August 31, 2022 14:20
@kbence kbence requested a review from ptgott August 31, 2022 14:20
@kbence kbence force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from 40bb7a8 to d719b16 Compare August 31, 2022 14:24
@kbence kbence force-pushed the bence/update-plugin-docs-with-helm-charts/pagerduty branch from d719b16 to 5731f2d Compare August 31, 2022 15:34
@kbence kbence merged commit 5e476ed into master Aug 31, 2022
@github-actions
Copy link

@kbence See the table below for backport results.

Branch Result
branch/v10 Failed

@kbence kbence deleted the bence/update-plugin-docs-with-helm-charts/pagerduty branch August 31, 2022 16:02
@ptgott
Copy link
Contributor

ptgott commented Sep 2, 2022

TODO: @ptgott Create a backport for this once this PR is merged: #16052

ptgott added a commit that referenced this pull request Sep 12, 2022
Backports #15498
Backports #13729

- Update the PagerDuty plugin guide and add context
- Document the PagerDuty plugin Helm chart
ptgott added a commit that referenced this pull request Sep 28, 2022
Backports #15498
Backports #13729

- Update the PagerDuty plugin guide and add context
- Document the PagerDuty plugin Helm chart
ptgott added a commit that referenced this pull request Sep 28, 2022
* Backport PagerDuty edits

Backports #15498
Backports #13729

- Update the PagerDuty plugin guide and add context
- Document the PagerDuty plugin Helm chart

* Update docs/pages/reference/helm-reference/teleport-plugin-pagerduty.mdx

Co-authored-by: Alex Fornuto <[email protected]>

Co-authored-by: Alex Fornuto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants