Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always allow session owners to join own sessions + only list active trackers in WebUI #13660

Merged
merged 19 commits into from
Jun 22, 2022

Conversation

xacrimon
Copy link
Contributor

@xacrimon xacrimon commented Jun 20, 2022

Fixes #13595

This PR makes a couple of changes:

  • Filters out trackers marked as terminated in the WebAPI, preventing them from being shown in the session view.
  • Changes the RBAC engine to always allow session owners to join their own session.
  • Make web use the -teleport-internal-join principal when joining sessions.
  • Readd some changes we lost in a refactor to allow users to join with the special principal.

@xacrimon xacrimon marked this pull request as ready for review June 20, 2022 09:33
@github-actions github-actions bot requested review from espadolini and tcsc June 20, 2022 09:33
@Joerger
Copy link
Contributor

Joerger commented Jun 21, 2022

I'm seeing a few remaining issues here:

  • tsh join fails from the cli with ERROR: access denied to -teleport-internal-join connecting to 33e9a6a4-5986-40f7-b07c-90e6340c38c4 on cluster example.com
  • listed sessions in the webui have the host use listed 3 times, like: admin [], admin [], admin []
  • Zombie sessions: If you close the server while sessions are open, then restart, you'll see the sessions are still in the webui. They are also still joinable somehow, and never go through the linger and die logic, because they think they still have an active participant.

Not sure if these are directly related to this issue or should be fixed in follow up PRs

@xacrimon
Copy link
Contributor Author

Checked and my PR should now address nr1.

@xacrimon xacrimon force-pushed the joel/tracker-rbac-s-filter branch from 12a3b24 to 34ad43c Compare June 22, 2022 18:58
@xacrimon xacrimon enabled auto-merge (squash) June 22, 2022 18:59
@xacrimon xacrimon merged commit 74f2440 into master Jun 22, 2022
@github-actions
Copy link

@xacrimon See the table below for backport results.

Branch Result
branch/v10 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't join/view sessions
3 participants