Manually instrument backend.Backend
#13268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `trace.Tracer` to the `backend.Reporter` wrapper so that all `bakend.Backend` implementations can be traced. Further instrumentation of each specific backend will be added at a later date to see how long each sql query, or call to dynamo/etcd took within each backend operation.
atburke
approved these changes
Jun 7, 2022
zmb3
reviewed
Jun 7, 2022
| attribute.String("name", watch.Name), | ||
| ), | ||
| ) | ||
| defer span.End() |
There was a problem hiding this comment.
I'm not sure how tracing fits in with watchers, as they are long running background tasks, right?
There was a problem hiding this comment.
This is only tracing the creation of a watcher. I was on the fence about including this as I wasn't sure how useful it would really be. But, I figured it was better to have it and not need it, than to not have it and wish we did.
zmb3
approved these changes
Jun 9, 2022
rosstimothy
added a commit
that referenced
this pull request
Jul 5, 2022
Adds a `trace.Tracer` to the `backend.Reporter` wrapper so that all `bakend.Backend` implementations can be traced. Further instrumentation of each specific backend will be added at a later date to see how long each sql query, or call to dynamo/etcd took within each backend operation. #12241
This was referenced Aug 11, 2022
reedloden
pushed a commit
that referenced
this pull request
Aug 15, 2022
Manually instrument `backend.Backend` (#13268) Adds a `trace.Tracer` to the `backend.Reporter` wrapper so that all `bakend.Backend` implementations can be traced. Further instrumentation of each specific backend will be added at a later date to see how long each sql query, or call to dynamo/etcd took within each backend operation. #12241
hydridity
pushed a commit
to hydridity/teleport
that referenced
this pull request
Aug 26, 2022
Manually instrument `backend.Backend` (gravitational#13268) Adds a `trace.Tracer` to the `backend.Reporter` wrapper so that all `bakend.Backend` implementations can be traced. Further instrumentation of each specific backend will be added at a later date to see how long each sql query, or call to dynamo/etcd took within each backend operation. gravitational#12241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
trace.Tracerto thebackend.Reporterwrapper so that all
bakend.Backendimplementationscan be traced. Further instrumentation of each specific
backend will be added at a later date to see how long
each sql query, or call to dynamo/etcd took within
each backend operation.
#12241